Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tests can failed on different order executions #17885

Merged
merged 2 commits into from
Dec 29, 2021
Merged

fix: tests can failed on different order executions #17885

merged 2 commits into from
Dec 29, 2021

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Dec 29, 2021

SUMMARY

test setup improved and fix the problems

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 29, 2021 •
edited
Loading

Codecov Report

Merging #17885 (3661d38) into master (ef57bd1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17885   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files        1609     1609           
  Lines       64897    64897           
  Branches     6866     6866           
=======================================
  Hits        43426    43426           
  Misses      19605    19605           
  Partials     1866     1866
Flag Coverage Δ
mysql 82.19% <ø> (ø)
postgres 82.24% <ø> (ø)
python 82.32% <ø> (ø)
sqlite 81.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef57bd1...3661d38. Read the comment docs.

amitmiran137
amitmiran137 approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitmiran137 amitmiran137 merged commit 886e4ef into apache:master Dec 29, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@ofekisr @shcoderAlex
fix: tests can failed on different order executions (apache#17885)
eba130e
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@ofekisr @bwang221
fix: tests can failed on different order executions (apache#17885)
c56da21
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitmiran137 amitmiran137 amitmiran137 approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ofekisr @amitmiran137 @mistercrunch